Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17725/3/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/17725/3/src/kudu/fs/fs_manager.cc@101 PS3, Line 101: DEFINE_int64(fs_wal_dir_reserved_bytes, -1, > Flags should only be defined once, so we should remove the definition in th That's done already. The definition is removed from consensus/log.cc http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc@446 PS2, Line 446: // Calculates the total free space on all the data directories combined accounting for > Yes. It could be inlined too if you want to avoid the overhead of calling a Thanks, I am trying to understand the benefit of having a separate function. if (!options.env->GetSpaceInfo(data_dir, &space_info_datadir).ok()) { return -1; } will be replaced by something like: Status s = GetDirSpace(options, data_dir, space_info_datadir) if (!s.ok()) { return -1; } And GetDirSpace function will be calling GetSpaceInfo. Is my understanding correct? -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 02 Aug 2021 14:58:16 +0000 Gerrit-HasComments: Yes
