Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 2: (2 comments) Not much more to add on top of what Alexey mentioned. http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt File src/kudu/server/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt@62 PS2, Line 62: consensus > Yes, it is needed to access the flag fs_wal_dir_reserved_bytes which is def Could we move the definition of the fs_wal_dir_reserved_bytes to, e.g. fs_manager.cc, and only DECLARE_int64() in consensus/log.cc? It does seem a bit odd to include 'consensus' here, given there isn't a strong connection between it and the sever module. http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc@431 PS2, Line 431: ServerBaseOptions options > Why not to pass ServerBaseOptions as a const reference? +1 -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Jul 2021 20:35:41 +0000 Gerrit-HasComments: Yes
