Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt File src/kudu/server/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt@62 PS2, Line 62: consensus > +1 to the approach suggested by Andrew. Done http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/server_base.cc@446 PS2, Line 446: total_free_space += space_info_datadir.free_bytes - FLAGS_fs_data_dirs_reserved_bytes; > maybe this could be refactored so that both GetDataDirAvailableSpace and Ge So if I am understanding it right, you are suggesting a new function which returns the free space in a given directory and this can be used by GetDataDirAvailableSpace and GetWalDirAvailable? -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 29 Jul 2021 21:47:16 +0000 Gerrit-HasComments: Yes
