Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] KUDU-2671: Pruning compatible with custom hash schemas. ...................................................................... Patch Set 4: Verified+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1366 PS3, Line 1366: > I just reused the existing test code that uses CHECK_OK(). What's the diffe Bad asserts result in the test being marked as failed, while a CHECK failure results in the process crashing. A failed test is much easier to diagnose and report compared to a crash. And depending on the test, e.g. in a multi-process test like one that uses an ExternalMiniCluster, a crash may not even result in a test failure without explicit checking for crashed processes. http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1428 PS3, Line 1428: int8_t>(4, 4, 0), 7, 7); > nope, have to explicitly use `make_tuple`. Just to clarify the suggestion is: CreatePartitionSchemaPB({"A"}, { { columns, 3, 0 } }, &pb); or CreatePartitionSchemaPB({"A"}, { { { "A", "B" }, 3, 0 } }, &pb); which _should_ work. I think compilers have issues with inferring types for optionals (e.g. in the check() lambdas), but that shouldn't be the case here or with AddRangePartitionWithSchema(). http://gerrit.cloudera.org:8080/#/c/17643/4/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17643/4/src/kudu/common/partition_pruner.cc@481 PS4, Line 481: auto & nit: ampersand should be right after "auto" -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 30 Jul 2021 18:57:22 +0000 Gerrit-HasComments: Yes
