Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/17731 )
Change subject: KUDU-1921 Add ability to require auth/encryption to C++ client
......................................................................
Patch Set 7:
It seems there are some build issues with PS7:
12:23:58
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/security-itest.cc:
In member function 'virtual void
kudu::EncryptionPolicyTest_TestEncryptionPolicy_Test::TestBody()':
12:23:58
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/security-itest.cc:700:8:
error: 'get' was not declared in this scope
12:23:58 if (!get<1>(params)) {
12:23:58 ^~~
It seems IWYU isn't happy yet:
>>> Fixing #includes in
>>> '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/security-itest.cc'
@@ -25,12 +25,12 @@
#include <memory>
#include <ostream>
#include <string>
+#include <tuple>
#include <vector>
#include <gflags/gflags_declare.h>
#include <glog/logging.h>
#include <gtest/gtest.h>
-#include <kudu/client/client.h>
#include "kudu/client/client-test-util.h"
#include "kudu/client/client.h"
IWYU would have edited 1 files on your behalf.
--
To view, visit http://gerrit.cloudera.org:8080/17731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e800eb7c4e2f8787f0adf1f040d47358d29320
Gerrit-Change-Number: 17731
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 06 Aug 2021 22:25:28 +0000
Gerrit-HasComments: No
