Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17731 )
Change subject: KUDU-1921 Add ability to require auth/encryption to C++ client ...................................................................... Patch Set 8: Code-Review+1 (3 comments) Overall looks good to me, just a few nits on the naming for the policy names. http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@233 PS8, Line 233: encryption nit: on-the-wire encryption http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@238 PS8, Line 238: REQUIRED nit: maybe, REQUIRED_EXCLUDING_LOOPBACK ? The point here is that REQUIRED sounds like it's indeed required everywhere, but adding an exact specification where it's not sounds a bit clearer, IMHO. http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@241 PS8, Line 241: REQUIRED_LOOPBACK nit: maybe, REQUIRED ? REQUIRED_LOOPBACK sounds focused on loopback connections, but otherwise not very descriptive for the rest. -- To view, visit http://gerrit.cloudera.org:8080/17731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e800eb7c4e2f8787f0adf1f040d47358d29320 Gerrit-Change-Number: 17731 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 09 Aug 2021 21:41:27 +0000 Gerrit-HasComments: Yes
