Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17731 )
Change subject: KUDU-1921 Add ability to require auth/encryption to C++ client ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@233 PS8, Line 233: on-the-wir > nit: on-the-wire encryption Done http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@238 PS8, Line 238: REQUIRED > nit: maybe, REQUIRED_EXCLUDING_LOOPBACK ? Changed it to REQUIRED_REMOTE, EXCLUDING_LOOPBACK seemed too long to me. http://gerrit.cloudera.org:8080/#/c/17731/8/src/kudu/client/client.h@241 PS8, Line 241: REQUIRED > nit: maybe, REQUIRED ? Done -- To view, visit http://gerrit.cloudera.org:8080/17731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e800eb7c4e2f8787f0adf1f040d47358d29320 Gerrit-Change-Number: 17731 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Aug 2021 14:18:02 +0000 Gerrit-HasComments: Yes
