Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 12: Thinking more on my previous comment, even if majority of the replicas are not down, lets say 1 out of three replicas is down, if we reduce the replication factor to 1, based on the below it appears it might choose the unhealthy replicas to evict, but a test case to be sure wouldn't hurt to ensure the healthy replicas are not evicted. https://github.com/apache/kudu/blob/master/src/kudu/master/catalog_manager.cc#L4873 OR Do we want to not change the replication factor if even one of the replicas is not running to be on a safe side. Probably Alexey/Andrew/Bankim can add their opinions -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 12 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 03:35:38 +0000 Gerrit-HasComments: No
