Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/17674/10/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/10/src/kudu/client/client-test.cc@8539 PS10, Line 8539: client_->data_->meta_cache_->ClearCache(); > Just to clarify here, I think Alexey is suggesting, rather than relying on Thanks Alexey, Andrew, I add some test cases in src/kudu/integration-tests/alter_table-test.cc, they are integration tests, without any internal calls, include modify RF while workload writing, scaning and WAL GCed. I think it is also reasonable to leave this test case here, to verify that the client is able to modify RF. How do you think? -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 13 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 14 Aug 2021 07:40:28 +0000 Gerrit-HasComments: Yes
