Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17764 )
Change subject: [common] more generic API for IN() predicate's pruning ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Thanks for this cleanup! http://gerrit.cloudera.org:8080/#/c/17764/2/src/kudu/common/scan_spec.cc File src/kudu/common/scan_spec.cc: http://gerrit.cloudera.org:8080/#/c/17764/2/src/kudu/common/scan_spec.cc@184 PS2, Line 184: // TODO(aserbin): is it possible that FindColumn() returns non-OK here? >From its usage in tablet_service, it seems like the answer is no. If the >predicate isn't in the tablet schema, the SetupScanSpec() call would return an >error when building the spec. http://gerrit.cloudera.org:8080/#/c/17764/2/src/kudu/common/scan_spec.cc@185 PS2, Line 185: DCHECK(false); nit: Maybe LOG(DFATAL)? Same below? -- To view, visit http://gerrit.cloudera.org:8080/17764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2390cc4747864fdac71656dd7125ac3b15bf9d Gerrit-Change-Number: 17764 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Aug 2021 17:37:46 +0000 Gerrit-HasComments: Yes
