Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17764 )
Change subject: [common] more generic API for IN list predicate pruning ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/17764/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17764/3//COMMIT_MSG@7 PS3, Line 7: IN( > nit: IN list? Done http://gerrit.cloudera.org:8080/#/c/17764/3//COMMIT_MSG@15 PS3, Line 15: IN > same as above Done http://gerrit.cloudera.org:8080/#/c/17764/3//COMMIT_MSG@23 PS3, Line 23: allow : for easier reading the assertion messages in case if those assertions : ever trigger. > nit: maybe replace with "increase readability of the assertion messages if Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/partition.h@239 PS3, Line 239: IN > nit: IN list? Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc@540 PS3, Line 540: Schema > nit: change to auto, more consistent with other callsites. Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc@839 PS3, Line 839: } > nit: add space before brace Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc@914 PS3, Line 914: IN( > nit: IN list Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc@917 PS3, Line 917: , > nit: remove comma Done http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec-test.cc@965 PS3, Line 965: TEST_F(CompositeIntKeysTest, TestLiftPrimaryKeyBounds_NoBounds) { > warning: avoid using "_" in test name "TestLiftPrimaryKeyBounds_NoBounds" a I'm going to ignore this warning since it's not related to the changes I did here :) http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec.h File src/kudu/common/scan_spec.h: http://gerrit.cloudera.org:8080/#/c/17764/3/src/kudu/common/scan_spec.h@79 PS3, Line 79: IN > nit: IN list Done -- To view, visit http://gerrit.cloudera.org:8080/17764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2390cc4747864fdac71656dd7125ac3b15bf9d Gerrit-Change-Number: 17764 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Aug 2021 23:34:37 +0000 Gerrit-HasComments: Yes
