Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17764 )
Change subject: [common] more generic API for IN list predicate pruning ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17764/4/src/kudu/common/scan_spec.cc File src/kudu/common/scan_spec.cc: http://gerrit.cloudera.org:8080/#/c/17764/4/src/kudu/common/scan_spec.cc@200 PS4, Line 200: auto s = row.Set(idx, reinterpret_cast<const uint8_t*>(value)); : !s.ok() > Woohoo C++17! Yep, this construct comes handy, and if I'm not mistaken some compilers supported that even before it appeared in the C++17 standard :) -- To view, visit http://gerrit.cloudera.org:8080/17764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2390cc4747864fdac71656dd7125ac3b15bf9d Gerrit-Change-Number: 17764 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 11 Aug 2021 02:14:29 +0000 Gerrit-HasComments: Yes
