Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17764 )
Change subject: [common] more generic API for IN list predicate pruning ...................................................................... [common] more generic API for IN list predicate pruning While working on KUDU-2671, I found that the exposed internals of the PartitionSchema class doesn't allow for updating the implementation of the partition-related code to include per-range custom hash bucket schemas in a consistent manner. This patch introduces a bit more generic interface for pruning values of IN list predicates by adding a new PartitionMayContainRow() method and removes the following methods from the public API of the PartitionSchema class: * HashPartitionContainsRow() * RangePartitionContainsRow() * IsColumnSingleRangeSchema() * TryGetSingleColumnHashPartitionIndex() I also added one extra test scenario and updated existing ones to increase readability of the assertion messages if they are triggered. This is a follow-up to 6a7cadc7e and 83b8caf4f. Change-Id: I2e2390cc4747864fdac71656dd7125ac3b15bf9d Reviewed-on: http://gerrit.cloudera.org:8080/17764 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/scan_spec-test.cc M src/kudu/common/scan_spec.cc M src/kudu/common/scan_spec.h 5 files changed, 417 insertions(+), 557 deletions(-) Approvals: Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e2390cc4747864fdac71656dd7125ac3b15bf9d Gerrit-Change-Number: 17764 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241)
