Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@456 PS10, Line 456: y) { > Yes, that makes sense. Done. This doesn't return anything when we're passed our expiration. Having this as an out parameter lets us no-op if the metric hasn't expired. http://gerrit.cloudera.org:8080/#/c/17725/11/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/11/src/kudu/server/server_base.cc@459 PS11, Line 459: return(CalculateAvailableSpace(options, fs_manager.GetWalsRootDir(), : nit: "return CalculateAvailable...(" Same elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 11 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Aug 2021 17:28:09 +0000 Gerrit-HasComments: Yes
