Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 12: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@446 PS10, Line 446: > Reverting this to static_cast<int64_t> as we see the below issue: Ah, I see -- makes sense. I didn't track this back to patchset4, sorry. http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@456 PS10, Line 456: ble_space_cache_seconds); > Changing back to out parameter in the next patch (patchset 12). This function is used only in one place, as I can see. Moving the logic into the metric functor completely might help to get rid of all these in-out and out parameters and those rules of populating these. But I don't feel strongly about this, was a bit surprised to see such a signature for a function, though. It's OK with me to keep it as is, though. http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@456 PS10, Line 456: ble_space_cache_seconds); > This doesn't return anything when we're passed our expiration. Having this Ah, that makes sense, but it's bit tricky anyway -- this function is used in just one place and has in-out and an out parameter. Let's keep it as is, maybe. http://gerrit.cloudera.org:8080/#/c/17725/12/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/12/src/kudu/server/server_base.cc@962 PS12, Line 962: ; nit: an extra semicolon -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Aug 2021 21:57:35 +0000 Gerrit-HasComments: Yes
