Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@446 PS10, Line 446: > Yes, it was 0LL in patchset 4. But I remember one of the test configuration Reverting this to static_cast<int64_t> as we see the below issue: 11:36:13 /home/jenkins-slave/workspace/kudu-master/0/src/kudu/server/server_base.cc:444:63: error: no matching function for call to 'max(long long int, int64_t)' 11:36:13 return std::max(0LL, space_info->free_bytes - reserved_bytes); http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/server/server_base.cc@456 PS10, Line 456: y) { > Ah, right thanks for pointing that out. Knew there was a reason for that bu Changing back to out parameter in the next patch (patchset 12). -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 11 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Aug 2021 21:28:53 +0000 Gerrit-HasComments: Yes
