Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17804 )
Change subject: [tool] Support to rewrite and print cmeta by batch ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@10 PS3, Line 10: it will cost a long time if there are many block containers. While I think this change is still a good improvement, I wonder if you've tried running the tool on recent versions of Kudu. Seems like we skip opening the block manager for cmeta-related tooling these days https://github.com/apache/kudu/blob/87a03ec9c6eeaf815cc03354937fb8fb24a79610/src/kudu/tools/tool_action_local_replica.cc#L306 http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/kudu-tool-test.cc@3464 PS3, Line 3464: ASSERT_STR_CONTAINS(lines[i], ts_uuids[0]); : ASSERT_STR_CONTAINS(lines[i], ts_uuids[1]); : ASSERT_STR_CONTAINS(lines[i], ts_uuids[2]); nit: given the above ASSERT_STR_MATCHES clause, these seem redundant? -- To view, visit http://gerrit.cloudera.org:8080/17804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33dcbf5704bce4265eae0bed0f4296d17e352780 Gerrit-Change-Number: 17804 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Aug 2021 22:42:33 +0000 Gerrit-HasComments: Yes
