Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17804 )
Change subject: [tool] Support to rewrite and print cmeta by batch ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@10 PS3, Line 10: it will cost a long time if there are many block containers. > While I think this change is still a good improvement, I wonder if you've t I encountered this issue when I used a 1.10 Kudu tool. I checked on 1.12 tool, it's faster. Thanks for your point out. http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/kudu-tool-test.cc@3464 PS3, Line 3464: ASSERT_STR_CONTAINS(lines[i], ts_uuids[0]); : ASSERT_STR_CONTAINS(lines[i], ts_uuids[1]); : ASSERT_STR_CONTAINS(lines[i], ts_uuids[2]); > nit: given the above ASSERT_STR_MATCHES clause, these seem redundant? The pattern I used can't match cases like: 'tablet: <tablet_id>, peers: ts_uuids[0] ts_uuids[0] ts_uuids[1]' So I check it again. -- To view, visit http://gerrit.cloudera.org:8080/17804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33dcbf5704bce4265eae0bed0f4296d17e352780 Gerrit-Change-Number: 17804 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 25 Aug 2021 05:32:54 +0000 Gerrit-HasComments: Yes
