Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17804 )
Change subject: [tool] Support to rewrite and print cmeta by batch ...................................................................... Patch Set 3: Code-Review+1 (6 comments) Thank you for the patch! http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@16 PS3, Line 16: The patch support nit: This patch adds support http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@17 PS3, Line 17: , nit: replace the command with '.' http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@317 PS3, Line 317: // Make a copy of the old file before rewriting it. nit: move this comment to line 326 right before the call to BackupConsensusMetadata() ? http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: Rewrite nit: Rewriting ? http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: raft nit: Raft http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: WARNING nit: INFO ? -- To view, visit http://gerrit.cloudera.org:8080/17804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33dcbf5704bce4265eae0bed0f4296d17e352780 Gerrit-Change-Number: 17804 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 25 Aug 2021 17:11:11 +0000 Gerrit-HasComments: Yes
