Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17804 )
Change subject: [tool] Support to rewrite and print cmeta by batch ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@16 PS3, Line 16: Change-Id: I33dcb > nit: This patch adds support Done http://gerrit.cloudera.org:8080/#/c/17804/3//COMMIT_MSG@17 PS3, Line 17: > nit: replace the command with '.' Done http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@317 PS3, Line 317: Env* env = Env::Default(); > nit: move this comment to line 326 right before the call to BackupConsensus Done http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: > nit: Raft Done http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: > nit: Rewriting ? Done http://gerrit.cloudera.org:8080/#/c/17804/3/src/kudu/tools/tool_action_local_replica.cc@324 PS3, Line 324: > nit: INFO ? Done -- To view, visit http://gerrit.cloudera.org:8080/17804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33dcbf5704bce4265eae0bed0f4296d17e352780 Gerrit-Change-Number: 17804 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 26 Aug 2021 15:38:36 +0000 Gerrit-HasComments: Yes
