Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17825 )
Change subject: KUDU-2671 allow a range to have no hash schema ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/client.cc@884 PS2, Line 884: // Using KuduTableCreator::add_range_partition() assumes the range partition So to summarize: 1. Use add_range_partition() when the range uses the table wide schema. 2. Use add_custom_range_partition() and add a custom hash schema. 3. Use add_custom_range_partition() and don't add a hash schema to signify empty hash bucketing. Just looking at the comments from client.h, can we clarify this https://github.com/apache/kudu/blob/master/src/kudu/client/client.h#L1308-L1309? Specifically, the last part saying 'different from a schema used for a range partition'. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@593 PS2, Line 593: // If current bound's HashSchema is empty, implies use of default Update comment as well. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@602 PS2, Line 602: int index = current_range_hash_schema.empty() ? -1 : i; I believe we can get rid of this line and just directly add index to 'partition_idx_to_hash_schema_idx'. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@656 PS2, Line 656: || partition_idx_to_hash_schema_idx[j] == -1 can remove this if change on L602 is successful. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition_pruner-test.cc@1207 PS2, Line 1207: A Comment is incorrect (my mistake), change to B = 0. -- To view, visit http://gerrit.cloudera.org:8080/17825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb Gerrit-Change-Number: 17825 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 08 Sep 2021 00:49:14 +0000 Gerrit-HasComments: Yes
