Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17825 )
Change subject: KUDU-2671 allow a range to have no hash schema ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17825/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17825/3/src/kudu/common/partition.cc@592 PS3, Line 592: const auto& current_range_hash_schema = bound.hash_schema; nit: can probably use 'bound.hash_schema' directly rather than using a variable given it's only used in one place now. http://gerrit.cloudera.org:8080/#/c/17825/3/src/kudu/common/partition.cc@654 PS3, Line 654: else Maybe this is for a separate patch, but I think updating the test with unbounded ranges so the last range has no hash bucketing would be good for testing purposes. -- To view, visit http://gerrit.cloudera.org:8080/17825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb Gerrit-Change-Number: 17825 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 08 Sep 2021 08:30:22 +0000 Gerrit-HasComments: Yes
