Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17825 )
Change subject: KUDU-2671 allow a range to have no hash schema ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/client.cc@884 PS2, Line 884: // Using KuduTableCreator::add_range_partition() assumes the range partition > So to summarize: Done http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/client/flex_partitioning_client-test.cc@412 PS2, Line 412: add_hash_partition > nit: add_custom_range_partition() add_custom_range_partition() is a method of KuduTableCreator; here the idea was to point that KuduRangePartition::add_hash_partition() hasn't been called on the object returned by CreateRangePartition. I updated the comment to make it clearer. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@593 PS2, Line 593: // If current bound's HashSchema is empty, implies use of default > Update comment as well. Good catch! Done. http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@602 PS2, Line 602: int index = current_range_hash_schema.empty() ? -1 : i; > I believe we can get rid of this line and just directly add index to 'parti Ah, indeed. Thanks! http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition.cc@656 PS2, Line 656: || partition_idx_to_hash_schema_idx[j] == -1 > can remove this if change on L602 is successful. Done http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/17825/2/src/kudu/common/partition_pruner-test.cc@1207 PS2, Line 1207: A > Comment is incorrect (my mistake), change to B = 0. Done -- To view, visit http://gerrit.cloudera.org:8080/17825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb Gerrit-Change-Number: 17825 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 08 Sep 2021 04:47:34 +0000 Gerrit-HasComments: Yes
