Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17825 )
Change subject: KUDU-2671 allow a range to have empty hash schema ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17825/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17825/4/src/kudu/client/client.h@1251 PS4, Line 1251: Besides, > nit: "Besides" is a bit informal. Perhaps use "Alternatively"? Good point. Done. http://gerrit.cloudera.org:8080/#/c/17825/4/src/kudu/client/client.h@1312 PS4, Line 1312: the table-wide hash : /// partitioning schema can be set using the : /// @c KuduTableCreator::add_hash_partitions() method > nit: it seems a bit odd to mention the table-wide hash schema here, given t Done -- To view, visit http://gerrit.cloudera.org:8080/17825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia43df69ecd7040e285e098fde49d84a7a00d1fbb Gerrit-Change-Number: 17825 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 08 Sep 2021 22:13:01 +0000 Gerrit-HasComments: Yes
