Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/client/client.h@750 PS7, Line 750: struct KUDU_EXPORT ListTableInfo { : std::vector<std::string> table_names; : std::vector<uint64_t> record_numbers; : std::vector<int> tablet_numbers; : std::vector<int> replica_numbers; : }; Instead of separate vectors for each field, need a structure that encapsulates all fields related to a table and then a vector of that structure. Like struct TableInfo { std::string table_name; uint64_t record_number; int tablet_number; int replica_number; } vector<TableInfo> list_table_info http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/master/master.proto@597 PS7, Line 597: required uint64 record_number = 3; : required int32 tablet_number = 4; : required int32 replica_number = 5; These new fields need to be optional. http://gerrit.cloudera.org:8080/#/c/17912/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17912/6/src/kudu/tools/kudu-tool-test.cc@4166 PS6, Line 4166: expected.push_back(Substitute("$0 Tablet_N:1 Replica_N:$1 Record_N:0", > warning: 'push_back' is called inside a loop; consider pre-allocating the v This is a reasonable comment from the bot. Please consider incorporating it. http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17912/7/src/kudu/tools/tool_action_table.cc@107 PS7, Line 107: tablet numbe Include statistics like tablet number, .... -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 7 Gerrit-Owner: yejiabao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 18:37:02 +0000 Gerrit-HasComments: Yes
