Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17912 )

Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'.
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/master/master.proto
File src/kudu/master/master.proto:

http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/master/master.proto@597
PS10, Line 597: record_number
nit: Maybe use x_count instead of x_number for better clarity?


http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/tool_action_table.cc@107
PS10, Line 107: like tablet number
nit: maybe replace it with "such as number of tablets"? Same with replica 
number and record number



--
To view, visit http://gerrit.cloudera.org:8080/17912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
Gerrit-Change-Number: 17912
Gerrit-PatchSet: 10
Gerrit-Owner: yejiabao <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: yejiabao <[email protected]>
Gerrit-Comment-Date: Thu, 21 Oct 2021 04:26:51 +0000
Gerrit-HasComments: Yes

Reply via email to