Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.h@758 PS10, Line 758: list_table_info The parameter name must match. http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc@614 PS10, Line 614: for (int i = 0; i < resp.tables_size(); i++) { : const auto& table = resp.tables(i); Better to use for range loop with resp.tables instead. http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/client/client.cc@621 PS10, Line 621: list_table_infos->push_back(list_table_info); emplace_back(std::move(list_table_info)) http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17912/10/src/kudu/tools/kudu-tool-test.cc@4093 PS10, Line 4093: int const int kReplicaNum -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 10 Gerrit-Owner: yejiabao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Wed, 20 Oct 2021 18:14:41 +0000 Gerrit-HasComments: Yes
