Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17912 )
Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'. ...................................................................... Patch Set 13: (1 comment) I'm late to reviewing this change, but I spotted an ABI-breaking change in this patch. I guess we need to revert this. http://gerrit.cloudera.org:8080/#/c/17912/13/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17912/13/src/kudu/client/client.h@748 PS13, Line 748: const std::string& filter = ""); : : struct KUDU_EXPORT ListTableInfo { : std::string table_name; : uint64_t live_row_count; : int num_tablets; : int num_replicas; : }; : /// List only those tables whose names pass a substring match on @c filter. : /// : /// @param [out] list_table_infos : /// The placeholder for the result. Appended only on success. : /// @param [in] filter : /// Substring filter to use; empty sub-string filter matches all tables. : /// @return Status object for the operation. : Status ListTables(std::vector<ListTableInfo>* list_table_infos, : const std::string& filter = ""); This change isn't ABI compatible and should be reverted. For API compatibility, see https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B -- To view, visit http://gerrit.cloudera.org:8080/17912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f Gerrit-Change-Number: 17912 Gerrit-PatchSet: 13 Gerrit-Owner: yejiabao <yejia...@huawei.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: yejiabao <yejia...@huawei.com> Gerrit-Comment-Date: Mon, 25 Oct 2021 23:39:19 +0000 Gerrit-HasComments: Yes
