Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [encryption] KUDU-3331 Encrypt file system ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc@106 PS9, Line 106: IsFileEncrypted > I guess at this point it's to determine if it's sensitive, but if we switch I wouldn't mind leaving it like this, so long as it's clear what's what. I suppose we'd also need to think about temp files too though. Maybe we ought to add a --force_file_is_sensitive=true/false/"" or somesuch for users to ignore this condition? Perhaps in a separate patch though http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/util/pb_util-test.cc File src/kudu/util/pb_util-test.cc: PS9: > Do you think it's worth adding a test that checks that we can't read a sens Missed this? -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Jan 2022 00:47:30 +0000 Gerrit-HasComments: Yes
