Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [encryption] KUDU-3331 Encrypt file system ...................................................................... Patch Set 9: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/17974/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/7//COMMIT_MSG@45 PS7, Line 45: tes. All tests below wer > Yes, added a note about it. Cool, thanks! http://gerrit.cloudera.org:8080/#/c/17974/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/9//COMMIT_MSG@32 PS9, Line 32: be nit: 'be' --> 'is' or maybe add 'can'? http://gerrit.cloudera.org:8080/#/c/17974/7/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/17974/7/src/kudu/util/env_posix.cc@1306 PS7, Line 1306: > I don't know about that, each file type uses separate *FileOptions types, s Ah, I was under impression FileOptions structs/classes have a common ancestor, but they aren't. With that I guess it's totally fine to keep it as is (it's just a nit, after all). http://gerrit.cloudera.org:8080/#/c/17974/6/src/kudu/util/rolling_log.cc File src/kudu/util/rolling_log.cc: http://gerrit.cloudera.org:8080/#/c/17974/6/src/kudu/util/rolling_log.cc@163 PS6, Line 163: opts.is_sensitive = false; > It's not necessarily needed, but it doesn't hurt. Also, it makes things sim SGTM, thanks for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 17 Dec 2021 22:27:32 +0000 Gerrit-HasComments: Yes
