[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/17995/10/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/10/src/kudu/master/dynamic_multi_master-test.cc@1767 PS10, Line 1767: idx > In this case, wouldn't idx be 2? Does it work if we use 3, since we've adde Yes, good catch. Currently it won't work if we set it to 3, as the cluster_->masters_ doesn't contain the added master, also cluster_->++opts_->num_masters is still 2. These are both private to ExternalMiniCluster and are set by AddMaster() when adding a new master the "normal" way. I'm considering adding some methods to be able to manually increment/set the masters and the opts, but I'd love some input if it's a good idea to expose these like that. -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Nov 2021 18:20:49 +0000 Gerrit-HasComments: Yes
