Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: PS9: Thanks for adding this test! http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1734 PS9, Line 1734: nit: add a couple spaces to be 4-spaces out from the prior line http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1765 PS9, Line 1765: ASSERT_OK(peer->WaitForCatalogManager()); Consider adding a call to VerifyVotersOnAllMasters() here? Perhaps wrapped in ASSERT_EVENTUALLY() in case the addition is slow? http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/mini-cluster/external_mini_cluster.h@519 PS9, Line 519: : // // Constructs an ExternalMaster based on 'opts_' but with the given set of : // // master addresses, giving the new master the address in the list : // // corresponding to 'idx'. Callers are expected to call Start() with the : // // output 'master'. : // // : // // It's expected that the port for the master at 'idx' is reserved, and that : // // the master can be run with the --rpc_reuseport flag. : // Status CreateMaster(const std::vector<HostPort>& master_rpc_addrs, int idx, : // scoped_refptr<ExternalMaster>* master); : Remove? -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 16 Nov 2021 20:00:08 +0000 Gerrit-HasComments: Yes
