[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1718 PS9, Line 1718: SKIP_IF_SLOW_NOT_ALLOWED(); > How long does it take to run this test? I see there are a bunch of other te Locally, this single test takes around 4-5s, I think what could take longer are the WaitForCatalogManager() and the ASSERT_EVENTUALLY() for VerifyVotersOnAllMasters(). These have to wait for the masters to start up. http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1734 PS9, Line 1734: > nit: add a couple spaces to be 4-spaces out from the prior line Ack http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1741 PS9, Line 1741: auto *flags > style nit: stick the asterisk to the type Ack http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1765 PS9, Line 1765: ASSERT_OK(peer->WaitForCatalogManager()); > Consider adding a call to VerifyVotersOnAllMasters() here? Perhaps wrapped Done http://gerrit.cloudera.org:8080/#/c/17995/9/src/kudu/master/dynamic_multi_master-test.cc@1766 PS9, Line 1766: } > Consider adding one more thing in the very end of this test scenario: Done -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 17 Nov 2021 18:26:30 +0000 Gerrit-HasComments: Yes
