Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17995 )
Change subject: [master] KUDU-3311 Allow to start with diff num of masters ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17995/5/src/kudu/master/dynamic_multi_master-test.cc@1477 PS5, Line 1477: TEST_F(AutoAddMasterTest, TestRestartMastersWhileSomeDown) { > I attempted to implement the test as you've described, however ExternalMini Is there any reason we can't make CreateMaster() public? http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/17995/1/src/kudu/master/sys_catalog.cc@296 PS1, Line 296: // We should prevent starting with fewer masters than previously. This way if the user wants to : // remove a master they would have to do it manually > Thank you for the clarification! It's definitely worth mentioning any additional (albeit manual) testing you've done in the commit message! -- To view, visit http://gerrit.cloudera.org:8080/17995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39aeee2f52a55a8c29770f748895d38c9adff8a2 Gerrit-Change-Number: 17995 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 11 Nov 2021 01:34:48 +0000 Gerrit-HasComments: Yes
