Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18057 )
Change subject: KUDU-3341: No further retry when DeleteTabet with WRONG_SERVER_UUID error ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/18057/3//COMMIT_MSG Commit Message: PS3: nit: can you shorten the subject line and reflow the body? Subjects should be kept short, but the body is normally wrapped at 80 characters when it's not a log message etc. http://gerrit.cloudera.org:8080/#/c/18057/3//COMMIT_MSG@11 PS3, Line 11: It's better to mark this RetryTask failed Can you add why this is safe to do to the commit message? http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc File src/kudu/integration-tests/delete_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@251 PS3, Line 251: num_tablet_servers nit: no need to add this comment as the variable name describes what this is. http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@273 PS3, Line 273: SleepFor(MonoDelta::FromSeconds(5)); Why do we need to wait here? Can't we just simply wait until ASSERT_EVENTUALLY() succeeds? http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@285 PS3, Line 285: SleepFor(MonoDelta::FromSeconds(5)); I guess this is to make sure that it's not retried for a sufficient amount of time, but this seems arbitrary. Should it be some multiple of raft heartbeat interval? http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/master/catalog_manager.cc@4149 PS3, Line 4149: LOG_WITH_PREFIX(WARNING) << Substitute("delete failed due to $0: $1. No further retry.", Can you leave the existing messages unchanged and just add a new case? Changing warning/error messages can make debugging across versions a pain, so it's best to avoid it when possible. http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/mini-cluster/internal_mini_cluster.cc File src/kudu/mini-cluster/internal_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/mini-cluster/internal_mini_cluster.cc@221 PS3, Line 221: Status InternalMiniCluster::AddTabletServer(const HostPort& hp) { can you make AddTabletServer() call this method? -- To view, visit http://gerrit.cloudera.org:8080/18057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa36086300bda7f958570c690b951dc090c342a Gerrit-Change-Number: 18057 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 30 Nov 2021 17:51:11 +0000 Gerrit-HasComments: Yes
