Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18057 )
Change subject: KUDU-3341: Stop retrying to DeleteTablet on wrong server ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18057/3//COMMIT_MSG Commit Message: PS3: > I have tried to shorten the subject line but it's still over 50 characters That's fine, 50 is not a hard limit, I was just surprised to see the subject line to be longer than the body. http://gerrit.cloudera.org:8080/#/c/18057/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18057/6/src/kudu/master/catalog_manager.cc@4167 PS6, Line 4167: LOG_WITH_PREFIX(WARNING) << Substitute("delete failed due to $0: $1. No further retry.", can you rephrase it to be more similar to the rest? -- To view, visit http://gerrit.cloudera.org:8080/18057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa36086300bda7f958570c690b951dc090c342a Gerrit-Change-Number: 18057 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 01 Dec 2021 17:32:32 +0000 Gerrit-HasComments: Yes
