Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18057 )
Change subject: KUDU-3341: Stop retrying to DeleteTablet on wrong server ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/18057/3//COMMIT_MSG Commit Message: PS3: > nit: can you shorten the subject line and reflow the body? Subjects should I have tried to shorten the subject line but it's still over 50 characters :( http://gerrit.cloudera.org:8080/#/c/18057/3//COMMIT_MSG@11 PS3, Line 11: than keep retrying to send too many reque > Can you add why this is safe to do to the commit message? Done http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc File src/kudu/integration-tests/delete_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@251 PS3, Line 251: umTabletServers)); > nit: no need to add this comment as the variable name describes what this i Done http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@273 PS3, Line 273: > Why do we need to wait here? Can't we just simply wait until ASSERT_EVENTUA Done http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/integration-tests/delete_tablet-itest.cc@285 PS3, Line 285: ASSERT_EQ(num_replicas, num_delete_tablet_rpcs); > I guess this is to make sure that it's not retried for a sufficient amount Yes, but it seems that the retry interval has nothing to do with raft heartbeat interval (https://github.com/apache/kudu/blob/150f3ee1a4c7a19ec46797928dc8b84e14b6c4a8/src/kudu/master/catalog_manager.cc#L3948). http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/master/catalog_manager.cc@4149 PS3, Line 4149: "because the tablet was not found. No further retry: $2", > Can you leave the existing messages unchanged and just add a new case? Chan Done http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/mini-cluster/internal_mini_cluster.cc File src/kudu/mini-cluster/internal_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/18057/3/src/kudu/mini-cluster/internal_mini_cluster.cc@221 PS3, Line 221: if (nodes == ClusterNodes::ALL || nodes == ClusterNodes::TS_ONLY) { > can you make AddTabletServer() call this method? Done -- To view, visit http://gerrit.cloudera.org:8080/18057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa36086300bda7f958570c690b951dc090c342a Gerrit-Change-Number: 18057 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 01 Dec 2021 16:37:15 +0000 Gerrit-HasComments: Yes
