Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18057 )
Change subject: KUDU-3341: Stop retrying to DeleteTablet on wrong server ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18057/1/src/kudu/integration-tests/delete_tablet-itest.cc File src/kudu/integration-tests/delete_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/18057/1/src/kudu/integration-tests/delete_tablet-itest.cc@241 PS1, Line 241: // Regression test for KUDU-3341: Ensure that master would not retry to send : // DeleteTablet() RPC to a "wrong > No, we don't really need 5 servers. I tested with 3 tservers and when re-ad After more testing I think we still need more than 3 tablet servers to make all behaviors predictable and easier to understand. In the last step of this test, i.e. restart the tserver with original uuid, we want to make sure that old replicas(if any) would finally be deleted even if master gave up deleting tablets when it failed on wrong_server_uuid error. But if we only have 3 tservers, in the end there would be also some replicas running on the tserver, which are newly replicated ones. Then it's hard to verify old replicas are actually deleted. -- To view, visit http://gerrit.cloudera.org:8080/18057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa36086300bda7f958570c690b951dc090c342a Gerrit-Change-Number: 18057 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 01 Dec 2021 17:20:49 +0000 Gerrit-HasComments: Yes
