Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 Disable compact on the specified table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18054/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18054/3//COMMIT_MSG@7 PS3, Line 7: KUDU-3340 Disable compact on the specified table Should this affect all compactions? Or just rowset merge compactions? http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/common/common.proto@476 PS3, Line 476: // It's a compact operation switch. : // If it was be setted to false, the table will not do compact. : optional bool enable_compact = 3; Typically these extra configs are "off by default". To follow that style, how about we call this "disable_rowset_compaction", so that the default case (where it's false) is the normal case where compactions are enabled. http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/tablet/tablet.cc@2394 PS3, Line 2394: // For tables that have been set to not do compact op, return directly : if (!enable_compact()) { : return workload_score; : } I don't think this is the score we want to be updating. You likely want to update the UpdateStats() methods in tablet_mm_ops.cc https://github.com/apache/kudu/blob/master/src/kudu/tablet/tablet_mm_ops.cc -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 10 Dec 2021 08:35:10 +0000 Gerrit-HasComments: Yes
