Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 Disable compact on the specified table ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/tablet/tablet.cc@2394 PS3, Line 2394: // For tables that have been set to not do compact op, return directly : if (!enable_compact()) { : return workload_score; : } I agree with Andrew. The `workload_score` is used to define how 'hot' tablets are in order to prioritize flush/compaction ops of hot tablets, and this feature is turned off by default (i.e. --enable_workload_score_for_perf_improvement_ops=false). That means we may still schedule compaction operations even if workload_score = 0. See the calculation of perf_score here: https://github.com/apache/kudu/blob/master/src/kudu/util/maintenance_manager.cc#L538 -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 10 Dec 2021 11:22:14 +0000 Gerrit-HasComments: Yes
