Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 Disable compact on the specified table ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/common/common.proto@477 PS4, Line 477: If it was be setted to true If set true http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/common/wire_protocol.cc@675 PS4, Line 675: *result = true; Is this necessary? http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/common/wire_protocol.cc@684 PS4, Line 684: kTableEnableCompact 'kTableDisableCompact' should be better. http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/tablet/tablet.h@506 PS4, Line 506: Returns Return http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/tablet/tablet_mm_ops.cc@117 PS4, Line 117: disable_rowset_compaction What about using tablet_->metadata()->extra_config() directly? http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/util/maintenance_manager.h@187 PS4, Line 187: last_worked_ Why we need this new viarable? Seems 'last_modified_' is enough. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 20 Dec 2021 10:08:58 +0000 Gerrit-HasComments: Yes
