Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 Disable compact on the specified table ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/common/common.proto@476 PS3, Line 476: // It's a compact operation switch. : // If it was be setted to false, the table will not do compact. : optional bool enable_compact = 3; > Typically these extra configs are "off by default". To follow that style, h +1 http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/18054/3/src/kudu/integration-tests/alter_table-test.cc@2536 PS3, Line 2536: } Does it make sense to add a test scenario which verifies that the actual functionality works as expected, i.e. the corresponding type of compaction isn't running for the table in question once compaction is disabled by the configuration property? It might be a separate scenario in some other test suite. -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 10 Dec 2021 18:18:21 +0000 Gerrit-HasComments: Yes
