Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18101 )
Change subject: [consensus] force fsync metadata on XFS ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/consensus/consensus_meta.cc@57 PS2, Line 57: a system crash. > nit: does it make sense to mention KUDU-2195 for reference? Done http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/consensus/consensus_meta.cc@58 PS2, Line 58: TAG_FLAG(cmeta_fsync_override_on_xfs, experimental); > Does it make sense to add the 'runtime' tag as well? Done http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/consensus/consensus_meta.cc@58 PS2, Line 58: experi > Do we really want to be this strict? Maybe, tagging it as 'experimental' c Done http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc@365 PS2, Line 365: if (!metadata_) { : return Status::NotFound("could not find a healthy instance file"); : } : const auto& meta_root_path = canonicalized_metadata_fs > Is it possible to turn this into a warning instead of an error, keeping 'me In running a server, I'd want to err on the side of visibility to users, rather than silently exposing corruption potential. -- To view, visit http://gerrit.cloudera.org:8080/18101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie97138e3522f20325be104d3665d887693b79a10 Gerrit-Change-Number: 18101 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 15 Dec 2021 23:35:59 +0000 Gerrit-HasComments: Yes
