Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18101 )

Change subject: [consensus] force fsync metadata on XFS
......................................................................

[consensus] force fsync metadata on XFS

We've seen issues like KUDU-2195 rear their heads more prominently on
XFS, sometimes requiring costly surgery to fix by restoring metadata if
all replicas lose their consensus metadata.

This patch adds to the band-aid flag --cmeta_force_fsync, checking if
the metadata is on an XFS mount, and if so, always fsyncing. This new
behavior is enabled by default with the --cmeta_fsync_override_on_xfs
flag.

Change-Id: Ie97138e3522f20325be104d3665d887693b79a10
Reviewed-on: http://gerrit.cloudera.org:8080/18101
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <[email protected]>
---
M src/kudu/consensus/consensus_meta.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
3 files changed, 36 insertions(+), 3 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified
  Attila Bukor: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/18101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie97138e3522f20325be104d3665d887693b79a10
Gerrit-Change-Number: 18101
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>

Reply via email to