Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18101 )
Change subject: [consensus] force fsync metadata on XFS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc@365 PS2, Line 365: } : } : if (!metadata_) { : return Status::NotFound("could not find a healthy in > How about checking this only cmeta_fsync_override_on_xfs is true? If it's f Makes sense. I opted to take Attila's approach, though I also stripped the runtime tag, since it may depend on this non-runtime-updatable value. -- To view, visit http://gerrit.cloudera.org:8080/18101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie97138e3522f20325be104d3665d887693b79a10 Gerrit-Change-Number: 18101 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Dec 2021 18:50:16 +0000 Gerrit-HasComments: Yes
