Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18101 )
Change subject: [consensus] force fsync metadata on XFS ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18101/2/src/kudu/fs/fs_manager.cc@365 PS2, Line 365: if (!metadata_) { : return Status::NotFound("could not find a healthy instance file"); : } : const auto& meta_root_path = canonicalized_metadata_fs > In running a server, I'd want to err on the side of visibility to users, ra Yup, that makes sense to me as well. Just wanted to make sure that's not going to block people using this on other than XFS. If you are sure it's not going to backfire in an unexpected way, that's totally fine, otherwise I'd consider adding a kill switch to turn this just into a warning. So far this looks pretty safe to me as of now :) -- To view, visit http://gerrit.cloudera.org:8080/18101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie97138e3522f20325be104d3665d887693b79a10 Gerrit-Change-Number: 18101 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Dec 2021 00:27:32 +0000 Gerrit-HasComments: Yes
