Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 Disable compact on the specified table ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/18054/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18054/10//COMMIT_MSG@7 PS10, Line 7: KUDU-3340 Disable compact on the specified table Add square brackets to describe the module you modified, could be [compaction] http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/tablet/tablet.h@508 PS10, Line 508: bool disable_rowset_compaction(); nit: declare as a const function http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/tablet/tablet_mm_ops.h File src/kudu/tablet/tablet_mm_ops.h: http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/tablet/tablet_mm_ops.h@45 PS10, Line 45: bool DisableCompact(); nit: also declare it as a const function http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/util/maintenance_manager.h@185 PS10, Line 185: setted set http://gerrit.cloudera.org:8080/#/c/18054/10/src/kudu/util/maintenance_manager.h@186 PS10, Line 186: setted set -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 10 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:13:22 +0000 Gerrit-HasComments: Yes
