KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18054 )
Change subject: KUDU-3340 [compaction] Disable compact on the specified table ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/18054/4/src/kudu/util/maintenance_manager.h@187 PS4, Line 187: last_worked_ > What about using `bool runnable()` to check compaction ops are disabled? Se Yes, we can use 'runnable()' only for this test scenario. However, by adding 'last_modified_', we can more clearly express our intention and facilitate further expansion in the future -- To view, visit http://gerrit.cloudera.org:8080/18054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8452bd9151f345fcad72bb9e0f07cd78432757e Gerrit-Change-Number: 18054 Gerrit-PatchSet: 12 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 28 Dec 2021 09:17:42 +0000 Gerrit-HasComments: Yes
