Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to remove a tablet server ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/master/ts_manager.cc@330 PS1, Line 330: servers_by_id_.erase(ts_uuid); > do you think it would be good to also remove the related entry from ts_stat Yes, the tserver's state would be removed here: https://gerrit.cloudera.org/c/18124/1/src/kudu/master/master_service.cc#355. http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/tool_action_common.cc@786 PS1, Line 786: > > shouldn't this be >= ? This is >1, for checking every master has same master_address. -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 10 Jan 2022 03:43:23 +0000 Gerrit-HasComments: Yes
