Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to remove a tablet server ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc@7490 PS1, Line 7490: RunActionStdoutStderrString(Su > nit: ts_uuid would be present in the ksck no matter what. Probably check fo Done http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc@7536 PS1, Line 7536: SSERT_STR_CONTAINS(err, ts_uuid); > Do we want to run the tool without the flag -force_remove_live_tserver and I think we should make sure the tserver has been brought down when using this tool, the error is to avoid removing a live tserver by mistake. -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 11 Jan 2022 09:51:36 +0000 Gerrit-HasComments: Yes
